Uncrispyfy NAV's custom crispy templates #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used extensively in /alertprofiles/matchfields/ and /threshold/add
Used somewhere in /arnold/ (could not find where exactly though) and in "'My stuff' quick links" under /preferences/ if you have saved any quick links
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 35s ⏱️ Results for commit 385d112. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3008 +/- ##
==========================================
- Coverage 56.76% 56.60% -0.16%
==========================================
Files 603 603
Lines 43720 43727 +7
Branches 48 48
==========================================
- Hits 24816 24752 -64
- Misses 18892 18963 +71
Partials 12 12 ☔ View full report in Codecov by Sentry. |
johannaengland
approved these changes
Sep 24, 2024
lunkwill42
changed the base branch from
master
to
uncrispyfy/foundation5-field
|
I took the liberty of changing the base to |
lunkwill42
requested changes
Sep 24, 2024
python/nav/web/templates/custom_crispy_templates/horizontal_checkbox.html
Outdated
Show resolved
Hide resolved
lunkwill42
approved these changes
Sep 24, 2024
hmpf
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces reusable templates to #2794:
horizontal_checkbox.htmlfor uncrispyfyingCheckBox()field_helptext_as_icon.htmlfor uncrispyfyingHelpField()Depends on #3000. So only last two commits are original, the rest will be rebased once #3000 is merged